-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support targetless agents. #1343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
force-pushed
the
targetless
branch
7 times, most recently
from
April 24, 2023 21:19
2962e0a
to
ac41424
Compare
aviramha
reviewed
Apr 25, 2023
t4lz
force-pushed
the
targetless
branch
2 times, most recently
from
April 25, 2023 09:57
1d0c932
to
0953c31
Compare
t4lz
force-pushed
the
targetless
branch
4 times, most recently
from
April 28, 2023 08:25
6a46f25
to
c4c0971
Compare
t4lz
force-pushed
the
targetless
branch
3 times, most recently
from
May 5, 2023 14:48
b5b4737
to
a662492
Compare
eyalb181
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks for your consideration, but approved! Well done.
aviramha
reviewed
May 11, 2023
aviramha
reviewed
May 11, 2023
Razz4780
reviewed
May 15, 2023
t4lz
force-pushed
the
targetless
branch
2 times, most recently
from
May 15, 2023 19:46
5c71b61
to
bd5cda8
Compare
E2E test. Make target optional on cli. support targetless runs in config and layer. Don't do sniff/steal work when agent is targetless Make explicit targetless argument for agent. changelog Add compatiblity checks for config. Run targetless first on the CI. kube and operator changes for operator. Make target config optional. But make `path` required for in `TargetConfig`. So we don't always have a `TargetConfig` (targetless if `None`), but if we have it, it has a path. make target optional in operator facing code. make agent namespace required for targetless in Operator API targetless agents unprivileged. Error on target namespace without target. targetless agent in target namespace with operator. use current namespace as agent namespace when targetless and operator. const for targetless target name. bypass bind on targetless
Co-authored-by: Michał Smolarek <34063647+Razz4780@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#574.
When not specifying any target, a targetless agent is spawned, which is independent of any other pod.