Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support targetless agents. #1343

Merged
merged 5 commits into from
May 17, 2023
Merged

Support targetless agents. #1343

merged 5 commits into from
May 17, 2023

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Apr 21, 2023

#574.

When not specifying any target, a targetless agent is spawned, which is independent of any other pod.

@t4lz t4lz force-pushed the targetless branch 7 times, most recently from 2962e0a to ac41424 Compare April 24, 2023 21:19
@t4lz t4lz force-pushed the targetless branch 2 times, most recently from 1d0c932 to 0953c31 Compare April 25, 2023 09:57
@t4lz t4lz marked this pull request as ready for review April 25, 2023 09:58
@t4lz t4lz force-pushed the targetless branch 4 times, most recently from 6a46f25 to c4c0971 Compare April 28, 2023 08:25
@t4lz t4lz marked this pull request as draft April 28, 2023 15:13
@t4lz t4lz force-pushed the targetless branch 3 times, most recently from b5b4737 to a662492 Compare May 5, 2023 14:48
@t4lz t4lz marked this pull request as ready for review May 5, 2023 22:37
This was referenced May 8, 2023
Copy link
Member

@eyalb181 eyalb181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks for your consideration, but approved! Well done.

mirrord-schema.json Outdated Show resolved Hide resolved
mirrord/agent/src/error.rs Outdated Show resolved Hide resolved
mirrord/agent/src/error.rs Outdated Show resolved Hide resolved
mirrord/kube/src/api.rs Outdated Show resolved Hide resolved
mirrord/cli/src/execution.rs Outdated Show resolved Hide resolved
mirrord/layer/src/lib.rs Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@t4lz t4lz force-pushed the targetless branch 2 times, most recently from 5c71b61 to bd5cda8 Compare May 15, 2023 19:46
t4lz and others added 5 commits May 17, 2023 13:57
E2E test.

Make target optional on cli.

support targetless runs in config and layer.

Don't do sniff/steal work when agent is targetless

Make explicit targetless argument for agent.

changelog

Add compatiblity checks for config.

Run targetless first on the CI.

kube and operator changes for operator.

Make target config optional.

But make `path` required for in `TargetConfig`.
So we don't always have a `TargetConfig` (targetless if `None`),
but if we have it, it has a path.

make target optional in operator facing code.

make agent namespace required for targetless in Operator API

targetless agents unprivileged.

Error on target namespace without target.

targetless agent in target namespace with operator.

use current namespace as agent namespace when targetless and operator.

const for targetless target name.

bypass bind on targetless
Co-authored-by: Michał Smolarek <34063647+Razz4780@users.noreply.github.com>
@t4lz t4lz enabled auto-merge May 17, 2023 11:58
@t4lz t4lz added this pull request to the merge queue May 17, 2023
Merged via the queue into metalbear-co:main with commit 71f954c May 17, 2023
23 checks passed
@t4lz t4lz deleted the targetless branch May 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants